**Fix:** Chip a11y #991
Merged
**Fix:** Chip a11y #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interactivity or lack thereof
fabien0102
suggested changes
Apr 24, 2019
| @@ -17,58 +18,90 @@ export interface ChipProps extends DefaultProps { | |||
| children: React.ReactNode | |||
| } | |||
|
|
|||
| const height = 20 | |||
There was a problem hiding this comment.
Why? The theme value was not good enough for you? 🤔
There was a problem hiding this comment.
theme.space for height is an anti-pattern
fabien0102
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #990 and adds a11y superpowers to
Chip.