ConfigHandler: make updateIdeSettings work (better) #3456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConfigHandler.updateIdeSettings()
was largely ineffective because theideSettingsPromise
was stored in the ProfileLoader object, so updating to a newideSettingsPromise
resulted in the config being reloaded with the old settings. Fix this by passing theideSettingsPromise
as a parameter toIProfileLoader.doLoadConfig()
.I came up with this while working on a larger change (for automatic model selection), so I don't have a great example of when this would matter, but it does seem like this would affect the use of
ideSettings.userToken
incore/llm/llms/index.ts
-This patch does not fix the case where changing the settings affects what profiles (changes to
ideSettings.remoteConfigServerUrl
)Checklist