⦕ Complex brackets #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes brackets to be spelled out if they are not balanced. See jupyter-book/mystmd#1766
certik
reviewed
Jan 14, 2025
| } | ||
| // This could be improved to a single pass if we have an intermediate AST for writing typst | ||
| // However, we are just writing this out twice at the moment if we find unbalanced brackets. | ||
| return texToTypst(value, { writeOutBrackets: true }); |
There was a problem hiding this comment.
This is probably fine for now, since the unbalanced brackets are rare, so the most common case of balanced brackets will be fast.
There was a problem hiding this comment.
That was my thought.
My original solution was just to do this all the time, however, that gives some pretty verbose exports for very simple things like e_(f(x)) to e_(f paren.l x paren.r), which I didn't want to do. :)
I think in the future we should have an intermediate tree that is meant for writing, and then do the unbalanced test on that tree, then write to string.
Put this PR together to unblock near term as that is going to be a larger change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brackets to be spelled out if they are not balanced.
See jupyter-book/mystmd#1766