Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI #134

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Fix broken CI #134

merged 1 commit into from
Apr 11, 2017

Conversation

yuva29
Copy link
Contributor

@yuva29 yuva29 commented Apr 11, 2017

Signed-off-by: Yuva Shankar [email protected]

Signed-off-by: Yuva Shankar <[email protected]>
@gaurav-dalvi
Copy link

what is this change for ?

@dseevr
Copy link
Contributor

dseevr commented Apr 11, 2017

@gaurav-dalvi the logic for how "create" and "update" on LDAP configs worked changed in a recent PR, but this check was not updated

@yuva29
Copy link
Contributor Author

yuva29 commented Apr 11, 2017

@gaurav-dalvi Proxy CI has been failing due to some test failure. Its a fix for that

@dseevr dseevr merged commit 6771e8d into contiv:master Apr 11, 2017
Copy link
Contributor

@dseevr dseevr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yuva29 yuva29 deleted the fix_broken_CI branch April 11, 2017 23:53
@yuva29 yuva29 restored the fix_broken_CI branch April 12, 2017 18:02
dseevr pushed a commit to dseevr-dev/auth_proxy that referenced this pull request Dec 21, 2017
…er. (contiv#134)

* text size fixed

* network policy create policy button moved top right corner with working functionality.

* Tab getting highlighted in blue now. Changes reverted.

* network policy tab list, create and details page state updated.

* comments fixed. Also added Div in application group details

* small comment change

* removed prioritizationpolicylist.html

* final

* redirection tab not giving error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants