Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy/helpers.go: return a better message when the X-Auth-Token header is missing #150

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

dseevr
Copy link
Contributor

@dseevr dseevr commented Jun 21, 2017

Signed-off-by: Bill Robinson [email protected]

@dseevr dseevr requested a review from yuva29 June 21, 2017 21:35
@gaurav-dalvi gaurav-dalvi self-requested a review June 21, 2017 22:04
Copy link

@gaurav-dalvi gaurav-dalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dseevr
Copy link
Contributor Author

dseevr commented Jun 21, 2017

I gotta go onto the CI slave and delete a docker network which apparently didn't get cleaned up properly before this will pass

@dseevr dseevr force-pushed the better_token_header_error branch from ce4f9c4 to 351410a Compare June 21, 2017 22:56
@dseevr dseevr merged commit c3b765e into contiv:master Jun 21, 2017
@dseevr dseevr deleted the better_token_header_error branch June 21, 2017 23:57
dseevr pushed a commit to dseevr-dev/auth_proxy that referenced this pull request Dec 21, 2017
* heading fix with consideration of error message

* volume

* trial

* comments fixed.

* fixed servicelbs issue

* servicelb minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants