Fix crush when status line is enabled #4546
Triggered via pull request
June 19, 2024 19:18
christianparpart
christianparpart
synchronize
#1497
Status
Success
Total duration
13s
Artifacts
–
Annotations
21 warnings
|
triage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
clang-tidy:
src/vtbackend/Screen.h#L111
warning: variable name 'r' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const r = static_cast<unsigned>(static_cast<float>(color.red) / 255.0f * 0xFFFF);
^
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L111
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const r = static_cast<unsigned>(static_cast<float>(color.red) / 255.0F * 0xFFFF);
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L112
warning: variable name 'g' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const g = static_cast<unsigned>(static_cast<float>(color.green) / 255.0f * 0xFFFF);
^
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L112
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const g = static_cast<unsigned>(static_cast<float>(color.green) / 255.0F * 0xFFFF);
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L113
warning: variable name 'b' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const b = static_cast<unsigned>(static_cast<float>(color.blue) / 255.0f * 0xFFFF);
^
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L113
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const b = static_cast<unsigned>(static_cast<float>(color.blue) / 255.0F * 0xFFFF);
```
|
|
clang-tidy:
src/vtbackend/SequenceBuilder.h#L37
warning: constructor does not initialize these fields: _incrementInstructionCounter, _handler [cppcoreguidelines-pro-type-member-init]
src/vtbackend/SequenceBuilder.h:186:
```diff
- IncrementInstructionCounter _incrementInstructionCounter;
- Handler _handler;
+ IncrementInstructionCounter _incrementInstructionCounter{};
+ Handler _handler{};
```
|
|
clang-tidy:
src/vtbackend/SequenceBuilder.h#L48
warning: statement should be inside braces [readability-braces-around-statements]
```suggestion
if (vtParserLog) {
vtParserLog()("Parser error: {}", errorString);
}
```
|
|
clang-tidy:
src/vtbackend/SequenceBuilder.h#L76
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
void collect(char ch) { _sequence.intermediateCharacters().push_back(ch); }
^
```
|
|
clang-tidy:
src/vtbackend/SequenceBuilder.h#L80
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
void param(char ch) noexcept
^
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L111
warning: variable name 'r' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const r = static_cast<unsigned>(static_cast<float>(color.red) / 255.0f * 0xFFFF);
^
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L111
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const r = static_cast<unsigned>(static_cast<float>(color.red) / 255.0F * 0xFFFF);
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L112
warning: variable name 'g' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const g = static_cast<unsigned>(static_cast<float>(color.green) / 255.0f * 0xFFFF);
^
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L112
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const g = static_cast<unsigned>(static_cast<float>(color.green) / 255.0F * 0xFFFF);
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L113
warning: variable name 'b' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const b = static_cast<unsigned>(static_cast<float>(color.blue) / 255.0f * 0xFFFF);
^
```
|
|
clang-tidy:
src/vtbackend/Screen.h#L113
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const b = static_cast<unsigned>(static_cast<float>(color.blue) / 255.0F * 0xFFFF);
```
|
|
clang-tidy:
src/vtbackend/SequenceBuilder.h#L37
warning: constructor does not initialize these fields: _incrementInstructionCounter, _handler [cppcoreguidelines-pro-type-member-init]
src/vtbackend/SequenceBuilder.h:186:
```diff
- IncrementInstructionCounter _incrementInstructionCounter;
- Handler _handler;
+ IncrementInstructionCounter _incrementInstructionCounter{};
+ Handler _handler{};
```
|
|
clang-tidy:
src/vtbackend/SequenceBuilder.h#L48
warning: statement should be inside braces [readability-braces-around-statements]
```suggestion
if (vtParserLog) {
vtParserLog()("Parser error: {}", errorString);
}
```
|
|
clang-tidy:
src/vtbackend/SequenceBuilder.h#L76
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
void collect(char ch) { _sequence.intermediateCharacters().push_back(ch); }
^
```
|
|
clang-tidy:
src/vtbackend/SequenceBuilder.h#L80
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
void param(char ch) noexcept
^
```
|