Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since v0.5 requires macOS 14 #1650

Closed
wants to merge 1 commit into from
Closed

Conversation

peterjc
Copy link

@peterjc peterjc commented Nov 6, 2024

This is based on trying the recent releases, see #1649

Description

Update minimum version of macOS in the README file requirements section.

Motivation and Context

Avoids false hope in users with older Apple Mac that they can run the latest release.

How Has This Been Tested?

Tested recent releases under macOS 12.7.6 "Monterey" to determine the minimum version of macOS reported as required, see #1649.

Checklist:

  • I have read the CONTRIBUTING document in my spoken language, and understand the terms
  • I have updated (or added) the documentation accordingly.
  • I have added tests to cover my changes.
  • I have gone through all the steps, and have thoroughly read the instructions

This is based on trying the recent releases, see contour-terminal#1649
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 6, 2024
@whisperity
Copy link
Member

I don't think we should say version numbers there because it will be a constant chase of updates when new OSes come out. Who sets the minimum OS version anyway? Even the change to not having Intel binaries happened because GitHub changed their CI, it was not directly a conscious decision by this project I think.

@whisperity whisperity added the platform: macOS topics that directly address macOS platform label Nov 6, 2024
@peterjc
Copy link
Author

peterjc commented Nov 6, 2024

OK, then it would make sense to edit that point in the README to just say "macOS" and drop the version which currently is misleading (due to circumstances partly outside the project's control).

@Yaraslaut Yaraslaut added the no changelog Tells the CI to not require a changelog entry label Nov 8, 2024
@Yaraslaut
Copy link
Member

I close this PR since readme will be updated in #1653

@Yaraslaut Yaraslaut closed this Nov 14, 2024
@peterjc peterjc deleted the patch-1 branch November 14, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no changelog Tells the CI to not require a changelog entry platform: macOS topics that directly address macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants