Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control codes for Control+(5,6,7,8) input #1702

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

Yaraslaut
Copy link
Member

Closes #1701

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Jan 5, 2025
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be correct (compared with konsole and other TEs), but I could not find out any documentation reference on why Ctrl+Number is meant to be encoded like this.

@Yaraslaut Yaraslaut merged commit 98f81b6 into master Jan 5, 2025
31 checks passed
@Yaraslaut Yaraslaut deleted the fix/control_numbers branch January 5, 2025 17:59
@j4james
Copy link

j4james commented Jan 5, 2025

The Ctrl key combinations are all listed in DEC STD-070 in section 6.16 (Control Codes and Keystrokes) on page 6-170. It's also worth reading the earlier section 6.13.1 (Control Key Operations) starting on page 6-75, because that clarifies their intended use with international keyboards. I think the point of these keys is that they guarantee a way to generate control codes on keyboard layouts which wouldn't necessarily have all the punctuation characters.

@christianparpart
Copy link
Member

Ah, many thanks @j4james. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control-6 inputs just 6
3 participants