Skip to content

Fix crush when status line is enabled

Sign in for the full log view
GitHub Actions / clang-tidy-review completed May 26, 2024 in 0s

clang-tidy-review

There were 3 warnings

Details

src/vtbackend/Terminal.cpp:1262: warning: all parameters should be named in a function [readability-named-parameter]
src/vtbackend/Terminal.cpp:1270: warning: variable name 'c' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/Terminal.cpp:1270: warning: statement should be inside braces [readability-braces-around-statements]

Annotations

Check warning on line 1262 in src/vtbackend/Terminal.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: all parameters should be named in a function [readability-named-parameter]

```suggestion
    [[nodiscard]] size_t writeText(std::string_view chars, size_t /*unused*/)
```

Check warning on line 1270 in src/vtbackend/Terminal.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: variable name 'c' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
        for (auto c: chars)
                  ^
```

Check warning on line 1271 in src/vtbackend/Terminal.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: statement should be inside braces [readability-braces-around-statements]

```suggestion
        for (auto c: chars) {
            targetScreen.writeText(c);
}
```