fix: only use intrinsics SIMD on x86_64 and aarch64 by default #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryolitia
force-pushed
the
master
branch
2 times, most recently
from
0f85ef3 to
8a44063
Compare
Cryolitia
changed the title
Yaraslaut
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Thamks a lot @Cryolitia , just a minor wording change is required :)
Yaraslaut
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #109
Now we only have the implements of intrinsics SIMD on x86_64 and aarch64. We could just enable the std SIMD on other platforms. Since we have
__has_include(<experimental/simd>), so that it's not a big deal if the target platform even doesn't have the std platform and just fall back to non-SIMD. And we could believe in that once the c++ standard library supports a new platform, we could get benefits in it immediately.Tested on Arch Linux x86_64 and Arch LInux RISC-V