Fix config-lerna-scopes with recent lerna versions #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Have you tested this with previous lerna versions? |
|
I am not sure how to properly test it (might be a good idea to add some tests here :)). |
|
Ok thanks, I'll push some tests here and merge then. |
|
Moving to #89, can't figure out the push to pr feature of Github. |
|
I added some unit and integration tests based on ava here marionebl/commitlint@32a5ee8. Will land your changes when #89 turns out green. Thanks again! |
|
Great! I can't wait to use it. Thank you! |
|
Opened the follow-up to this at lerna/lerna#1071 |
bpedersen
pushed a commit
to bpedersen/commitlint
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87.