Add support for MUC private messages #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now store messages on the `MUCOccupant` type, which is the first time we're storing messages on a non-chatbox. So to handle this, we created a new mixin model, `ModelWithMessages`, which can be extended by any model (not just chatboxes) and give that model messaging ability. We also turn ColorAwareModel and ModelWithMessages into mixins. Updates #698
…' state Get rid of the `overrides` in the minimize plugin.
We want to use the sidebar to show other things besides the occupants.
- Try to whittle down the color variables to the bare minimum. - Remove unnecessary CSS variables. - Thicker border around chat bottom panel
And move styles into more appropriate files.
- Add link to open chat from occupant view - Add dropdown menu
So that `converse-chat-content` can be kept more generic. Set the model directly on the `*-chat-content` components, instead of passing in the JID, so that the component doesn't have to know where to fetch the model from.
in the MUC sidebar. Updates #698
I want to make it possible to add contacts with no presence subscription, so technically contacts that aren't in the roster, so that we can see them in the controlbox sidebar when we have chats open with them.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jcbrand
force-pushed
the
jcbrand/muc-private-messages
branch
from
cd86677 to
e441fc4
Compare
jcbrand
force-pushed
the
jcbrand/muc-private-messages
branch
from
e441fc4 to
10c0693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #698