Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rack Param EcsContainerStopTimeout #3747

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

numcys
Copy link
Contributor

@numcys numcys commented Nov 1, 2024

What is the feature/update/fix?

Feature: New Rack Parameter for ECS Container Stop Timeout

We have introduced a new rack parameter, EcsContainerStopTimeout, that allows you to set a custom timeout duration for stopping ECS containers. This parameter controls the time before ECS issues a SIGKILL after sending a SIGTERM to the container, allowing more time for graceful shutdowns where needed.

By default, EcsContainerStopTimeout is set to a null value, which means it will defer to the ECS default 30-second stop timeout or any custom configurations already set at the ECS level. This approach ensures that no existing configurations or behaviors are affected unless you explicitly set a value.

This parameter can be particularly useful for applications that require extra time to shut down properly, such as those with ongoing user sessions or complex cleanup processes.

For more information, refer to the AWS StopTask Documentation.

How to use it?

To set the EcsContainerStopTimeout parameter, use the following command:

$ convox rack params set EcsContainerStopTimeout=<value> -r rackName
  • The <value> can be specified in seconds (s) or minutes (m). For example, both 60s and 1m are valid inputs and will set the timeout to 60 seconds.

Does it have a breaking change?

There are no breaking changes introduced with this feature.

Requirements

To use this feature, you must be on at least rack version 20241112202208.
You can check your rack's version with the command convox rack -r rackName.
Update your rack to the latest version with the command convox rack update -r rackName.

@numcys numcys requested a review from nightfury1204 November 1, 2024 16:10
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (20241111184017@1aedb67). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             20241111184017    #3747   +/-   ##
=================================================
  Coverage                  ?   33.17%           
=================================================
  Files                     ?      182           
  Lines                     ?    20540           
  Branches                  ?        0           
=================================================
  Hits                      ?     6814           
  Misses                    ?    12578           
  Partials                  ?     1148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightfury1204 nightfury1204 changed the base branch from master to 20241111184017 November 11, 2024 18:41
@nightfury1204 nightfury1204 merged commit 4a9b7ed into 20241111184017 Nov 11, 2024
4 checks passed
@nightfury1204 nightfury1204 deleted the param-add/ecs-container-stop-timeout branch November 11, 2024 18:42
@nightfury1204 nightfury1204 mentioned this pull request Nov 11, 2024
@numcys numcys restored the param-add/ecs-container-stop-timeout branch November 12, 2024 02:24
nightfury1204 pushed a commit that referenced this pull request Nov 12, 2024
* added rack param ecs_container_stop_timeout

* changed default value of EcsContainerStopTimeout param

* adding conditional logic on parameter
nightfury1204 pushed a commit that referenced this pull request Nov 12, 2024
* added rack param ecs_container_stop_timeout

* changed default value of EcsContainerStopTimeout param

* adding conditional logic on parameter
@ntner ntner changed the title Update on Default value for rack Param EcsContainerStopTimeout New Rack Param EcsContainerStopTimeout Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants