Add support for azure devops and visualstudio.com #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookpete
requested changes
Nov 7, 2018
CHANGELOG.md
Outdated
| @@ -4,287 +4,276 @@ All notable changes to this project will be documented in this file. Dates are d | |||
|
|
|||
| Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). | |||
|
|
|||
| #### [v1.8.1](https://github.com/CookPete/auto-changelog/compare/v1.8.0...v1.8.1) | |||
| #### [v1.8.1](https://github.com/Hwigaro/auto-changelog/compare/v1.8.1...v1.8.1) | |||
There was a problem hiding this comment.
You don't need to include any changes to the CHANGELOG.md in PRs. This is done automatically when creating a new version.
src/remote.js
Outdated
| } | ||
|
|
||
| return { | ||
| hostname, | ||
| url: `${protocol}//${hostname}/${repo}` | ||
| url: `${protocol}//${hostname}/${repo}`, | ||
| project: `${protocol}//${hostname}/${project}` |
There was a problem hiding this comment.
I think project is a weird name for this property. It looks like it's only used as the base url for issues? In which case maybe it should be issueUrl or something.
There was a problem hiding this comment.
Yes, it is used only for the issues url. But, since this url is used by Azure/Visualstudio as a base url for many other project functionalities, I named it project.
There was a problem hiding this comment.
Maybe projectUrl would be a more descriptive name.
Co-Authored-By: Hwigaro <[email protected]>
…-changelog into feature/azure-links
cookpete
approved these changes
Nov 8, 2018
|
Thanks @Hwigaro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #67. auto-changelog is a great tool and I want to use it on some projects but it doesn't support Azure DevOps.
Let me know if I must make some changes, I'll do it happily ❤️.