Use array index instead of Buffer.get #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2016 21:17
Buffer.get was depracted in 2013 [1] and removed entirely in Node 6 [2]. Closes #13. [1] nodejs/node#4587 [2] https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#buffer
bookercodes
pushed a commit
to base16-builder/base16-builder
that referenced
this pull request
May 6, 2016
The "slug" module has a transitive dependency called "bufferjs". "bufferjs" stopped working when Node 6 removed the Buffer.get method [1]. This broke all modules that depend on "bufferjs" in environments running Node 6. I sent a pull request [2] to fix "bufferjs" but I'm not hopeful it'll get merged any time soon. What's more, even my pull request *does* get merged, the "slug" module hasn't been updated in many months. Closes #105. [1] coolaj86/node-bufferjs#13 [2] coolaj86/node-bufferjs#14
|
Sorry that I'm a lazy bum (or a busy bee, whichever the case may be). I've made you a collab on the repo. Give me your npm username and I'll give you write access there too. |
|
Hi there AJ, No worries! I know you're busy (I heard you say so on a JavaScript Air I appreciate you giving me admin access to the repository and my npm username |
|
Added! |
|
Thanks, @coolaj86. I'll take care of all this tomorrow. |
bookercodes
force-pushed
the
master
branch
2 times, most recently
from
aeeb2e1 to
72c7763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer.getwas deprecated in 2013 (source) and removed entirely in Node 6 (source).Due to the removal of
Buffer.getthis module fails catastrophically in environments running Node 6. This impacts me because many modules depend onbufferjs(notablynode-slug).