tools/patch: apply patch for EACCES on xattr copy #10469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling OpenWRT on a compressed btrfs volume the build fails in libtool. The file `libltdl/config/ltmain.m4sh` from `libtool-2.4.2.tar.xz` is missing write permissions, therefore patch falls back to copying the file and patching that. During this patch tries to preserve all file attribute on the new copy. However the attribute `btrfs.compression` is privileged and btrfs return EACCES. While patch ignores multiple other error codes during the copy of xattr copy it is not prepared for EACCES and aborts. EACCES should be ignored the same way as the other errors. Build log: ``` ... Applying ./patches/000-relocatable.patch using plaintext: patching file libltdl/config/general.m4sh patching file libtoolize.in patching file libtoolize.m4sh patching file libltdl/m4/libtool.m4 Applying ./patches/100-libdir-fixes.patch using plaintext: patching file libltdl/config/ltmain.m4sh File libltdl/config/ltmain.sh is read-only; trying to patch anyway patching file libltdl/config/ltmain.sh patch: setting attribute btrfs.compression for btrfs.compression: Permission denied Patch failed! Please fix ./patches/100-libdir-fixes.patch! ``` Link: https://lists.gnu.org/archive/html/bug-patch/2022-11/msg00000.html Signed-off-by: Thomas Weißschuh <[email protected]>
github-actions bot
added a commit
to liyufan/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to Pengfei00/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to aiastia-bak/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to September999999999/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to HongJie-Master/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to Sneezyw/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to ZHYxulei/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to chingxuds/lede-custom
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to 2054686334/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to mchh1234/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to Jinnrry/lede
that referenced
this pull request
Nov 21, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
pushed a commit
to zesming/lede
that referenced
this pull request
Nov 22, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
github-actions bot
added a commit
to DeakeyTan/openwrt
that referenced
this pull request
Nov 22, 2022
* https://github.com/coolsnowwolf/lede: tools/patch: apply patch for EACCES on xattr copy (coolsnowwolf#10469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling OpenWRT on a compressed btrfs volume the build fails in libtool.
The file
libltdl/config/ltmain.m4shfromlibtool-2.4.2.tar.xzis missing write permissions, therefore patch falls back to copying the file and patching that. During this patch tries to preserve all file attribute on the new copy.However the attribute
btrfs.compressionis privileged and btrfs return EACCES.While patch ignores multiple other error codes during the copy of xattr copy it is not prepared for EACCES and aborts.
EACCES should be ignored the same way as the other errors.
Build log:
Link: https://lists.gnu.org/archive/html/bug-patch/2022-11/msg00000.html
Signed-off-by: Thomas Weißschuh [email protected]
Q：你知道这是
pull request吗？(使用 "x" 选择)