Merge pull request #160 from copiousfreetime/bugfix/windows-argv-list

Fix the generation of argv for ChildProcess
copiousfreetime · Jan 23, 2025 · 5c542d3 · 5c542d3
2 parents 8691074 + 4b2d358
commit 5c542d3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,4 +1,7 @@
 # Launchy Changelog
+## Version 3.1.0 - 2025-01-22
+* Fix the argv array when passing to ChildProcess on windows - <https://github.com/copiousfreetime/launchy/issues/159>
+
 ## Version 3.0.1 - 2024-05-03
 * Added rubocop and fix all the warnings
 * Fix rubygem changelog_uri - Spone

diff --git a/lib/launchy/runner.rb b/lib/launchy/runner.rb
@@ -19,8 +19,9 @@ def run(cmd, *args)
     end
 
     def wet_run(cmd, *args)
-      argv = [cmd, *args].flatten
+      argv = shell_commands(cmd, args)
       Launchy.log "ChildProcess: argv => #{argv.inspect}"
+
       process = ChildProcess.build(*argv)
 
       process.io.inherit!