Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coq-of-ocaml.2.1.0 #1205

Merged
merged 1 commit into from
May 20, 2020
Merged

Add coq-of-ocaml.2.1.0 #1205

merged 1 commit into from
May 20, 2020

Conversation

clarus
Copy link
Contributor

@clarus clarus commented Mar 20, 2020

No description provided.

@clarus
Copy link
Contributor Author

clarus commented Mar 20, 2020

I am investigating the issue. Surprisingly, only the any build fails.

@clarus clarus force-pushed the add-coq-of-ocaml-2.1.0 branch 4 times, most recently from 02a595c to bdcc73f Compare March 30, 2020 16:07
@clarus
Copy link
Contributor Author

clarus commented Mar 30, 2020

@here I would need some help to fix this pull-request. I do not really understand why it fails on the any plateforme. To me, the only difference is that there is a switch of compiler. The error is the following:

- dune build src/coqOfOCaml.exe
- Entering directory '/builds/coq/opam-coq-archive'
- File "opam-root-4.09.0-2.0.5-plain/4.09.0/bin/dune", line 1, characters 0-0:
- Error: Invalid dune file
- make: *** [Makefile:2: default] Error 1

It seems to me that dune is looking for dune files and finds itself.

@clarus clarus force-pushed the add-coq-of-ocaml-2.1.0 branch from bdcc73f to cf41fde Compare April 22, 2020 10:51
@clarus clarus force-pushed the add-coq-of-ocaml-2.1.0 branch from cf41fde to 93a058c Compare May 20, 2020 17:25
@gares
Copy link
Member

gares commented May 20, 2020

It works, what did you change?

@clarus clarus force-pushed the add-coq-of-ocaml-2.1.0 branch from 61474a0 to 93a058c Compare May 20, 2020 20:19
@clarus
Copy link
Contributor Author

clarus commented May 20, 2020

Ah, I tested another version of coq-of-ocaml. I think the change is not a fix actually because this version is compatible with OCaml 4.09 which is the version used by the any target. Hence the test do not do a change of OCaml compiler as before, and it works but just as the 4.09 target works.

So I remove the test commit and plan to merge it as it.

@clarus clarus merged commit 49600b8 into coq:master May 20, 2020
@clarus clarus deleted the add-coq-of-ocaml-2.1.0 branch May 20, 2020 20:53
@clarus clarus mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants