Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy message #471

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Remove legacy message #471

merged 5 commits into from
Nov 19, 2024

Conversation

ticruz38
Copy link
Collaborator

Removing legacy message completely

  • Show a warning on the top right of the screen if one pubkey is missing an inbox relay as in Flotilla
  • Removed the NIP17 toggle as it is now the default.
  • Still show a confirm modal if one pubkey is missing an inbox relay

staab
staab reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@staab staab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple nitpicks, and a few additional things:

  • can you fix the border on the right side of the compose input? It doesn't quite make it to the bottom
  • Related, there is a margin below compose for the toggle that is no longer necessary, see below.

Screenshot 2024-11-13 at 12 03 11 PM

src/app/views/ChannelsDetail.svelte Outdated Show resolved Hide resolved
src/app/views/ChannelsDetail.svelte Outdated Show resolved Hide resolved
@ticruz38 ticruz38 force-pushed the delete/nip04 branch 2 times, most recently from 09d7a85 to 78fc7b6 Compare November 18, 2024 09:09
staab
staab reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@staab staab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message box looks better, but still doesn't stretch to the full container height:

Screenshot 2024-11-18 at 11 55 07 AM

src/app/views/ChannelsDetail.svelte Outdated Show resolved Hide resolved
@staab staab merged commit 270e962 into coracle-social:dev Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staab staab staab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ticruz38 @staab