-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance note status #487
Enhance note status #487
Conversation
Nice, a few comments:
|
cc74996
to
d06bef4
Compare
Cool, I like all of this. Maybe left-align the select buttons though. Otherwise, let me know when it's ready for review and I'll take a closer look. |
It should be fine to review now Have created 2 new components, in the view folder, PublishesNotices and PublishesConnections, the plan was to have them link to the router but it proved more challenging than expected with the tabs. So these 2 views are just 2 child components for Publishes. I can move them to another folder if it makes more sense |
c04ad6e
to
7e07291
Compare
9f27fb7
to
5ccb27c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few things:
- Enhance note status #487 (comment) still needs to be resolved
- On the notices page, let's replace the relay selector with a generic "search" box. This should match against relay url, verb (ok/notice), and message.
- The animation on the notices page is janky, use
in
rather thantransition
. - While I like the granularity on the notices page, I agree with your point that storing all this is going to be pretty heavy, for not very much benefit. Let's slim it down to OK and NOTICE.
- Let's factor the thunks page out into its own component as well.
220c623
to
6abf5ea
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's actually add CLOSED
back in (my mistake).
cc06337
to
10e0fc9
Compare
|
To make them configurable essentially, I did not know exactly which verbs should be whitelisted |
- Publishes view refactor
14e5501
to
dfceba3
Compare
Related to #371
Notices are kind of unclear what should be displayed, I have the event, the status of the request and the relay url, not sure how to display this.
This is a draft, just look at the screenshot and give me some general feedback
Stats box are likely too big, you can see a timeout attached to some relay
Here the relay display how many successful events where posted to it