Issue #275: update to chromedriver #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2017
|
New PR to be opened shortly. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #278; I squashed the commits for a cleaner history.
REVIEW PROCEDURE
Follow the instructions in
TESTS.mdon a local/test system and see if they work for you.I’ve spent a good amount of time trying this in different environments. I have it working in Ubuntu 14.04 with PHP 5.6 and 16.04 with PHP 7.1.
Please Note: The tests will likely fail, but the testing environment should be set up properly. I will file more issues for fixes to the existing tests.