Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take it or leave it #1

Merged
merged 11 commits into from
Nov 14, 2023
Merged

take it or leave it #1

merged 11 commits into from
Nov 14, 2023

Conversation

paulwrath1223
Copy link
Contributor

I needed to clean some stuff up for my own use, but I figured id PR so you can keep the changes if you want.

I added basic support for timecodes, fixed typos, and made small tweaks to things that I didn't like.

The commits are going to be trash and non functional because I used this repo to share code between my home PC and the laptop I use to write code while pretending to pay attention in class, so only the last commit is good.

Also I might make a fully fledged WLED library with support for the other protocols like JSON API, so hopefuly you don't mind if I copy and paste some useful bits from this.

@paulwrath1223 paulwrath1223 marked this pull request as ready for review November 10, 2023 06:59
Removed Controller and now use DDPConnection as base class
@coral
Copy link
Owner

coral commented Nov 14, 2023

@paulwrath1223 nice

@coral coral reopened this Nov 14, 2023
@coral
Copy link
Owner

coral commented Nov 14, 2023

the only thing i dislike is the unwraps in the lib but i'll fix that and merge

@coral coral merged commit fadb352 into coral:master Nov 14, 2023
@coral
Copy link
Owner

coral commented Nov 14, 2023

my bad i skimmed it, no unwraps i cared about, merged.

@paulwrath1223 i used it to drive

https://www.youtube.com/watch?v=0l2mkmrPq7s

but my controller code is trash so let me know what you build, will be interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants