-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
take it or leave it #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Controller and now use DDPConnection as base class
@paulwrath1223 nice |
the only thing i dislike is the unwraps in the lib but i'll fix that and merge |
my bad i skimmed it, no unwraps i cared about, merged. @paulwrath1223 i used it to drive https://www.youtube.com/watch?v=0l2mkmrPq7s but my controller code is trash so let me know what you build, will be interesting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to clean some stuff up for my own use, but I figured id PR so you can keep the changes if you want.
I added basic support for timecodes, fixed typos, and made small tweaks to things that I didn't like.
The commits are going to be trash and non functional because I used this repo to share code between my home PC and the laptop I use to write code while pretending to pay attention in class, so only the last commit is good.
Also I might make a fully fledged WLED library with support for the other protocols like JSON API, so hopefuly you don't mind if I copy and paste some useful bits from this.