Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1266 @restpath failing on query string or extra path info #1267

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

cognitivegears
Copy link
Contributor

This PR proposes a fix for #1266.

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

@cognitivegears cognitivegears requested a review from a team as a code owner January 4, 2025 00:29
@jcchavezs jcchavezs requested a review from M4tteoP January 4, 2025 12:29
@fzipi
Copy link
Member

fzipi commented Jan 4, 2025

I wonder why no pipelines have run here 🤔

@cognitivegears
Copy link
Contributor Author

I wonder why no pipelines have run here 🤔

It's because I'm a first time contributor to this project- the pipelines require approval from a maintainer in order to run.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (07571c6) to head (7f29504).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1267      +/-   ##
==========================================
+ Coverage   81.69%   81.76%   +0.06%     
==========================================
  Files         169      169              
  Lines        9770     9770              
==========================================
+ Hits         7982     7988       +6     
+ Misses       1537     1533       -4     
+ Partials      251      249       -2     
Flag Coverage Δ
coraza.rule.case_sensitive_args_keys 81.71% <100.00%> (+0.06%) ⬆️
coraza.rule.multiphase_valuation 81.76% <100.00%> (+0.06%) ⬆️
coraza.rule.no_regex_multiline 81.69% <100.00%> (+0.06%) ⬆️
default 81.76% <100.00%> (+0.06%) ⬆️
examples+ 16.54% <0.00%> (ø)
examples+coraza.rule.case_sensitive_args_keys 81.71% <100.00%> (+0.06%) ⬆️
examples+coraza.rule.multiphase_valuation 81.59% <100.00%> (+0.06%) ⬆️
examples+coraza.rule.no_regex_multiline 81.61% <100.00%> (+0.06%) ⬆️
examples+memoize_builders 81.71% <100.00%> (+0.06%) ⬆️
examples+no_fs_access 81.04% <100.00%> (+0.06%) ⬆️
ftw 81.76% <100.00%> (+0.06%) ⬆️
memoize_builders 81.85% <100.00%> (+0.06%) ⬆️
no_fs_access 81.20% <100.00%> (+0.06%) ⬆️
tinygo 81.72% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There is an extra blank line that we can remove and I think we can merge. I'm trying to think more border cases, but at least there is additional coverage now.

internal/operators/restpath.go Outdated Show resolved Hide resolved
@cognitivegears
Copy link
Contributor Author

Removed additional blank line.

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me also!

@M4tteoP M4tteoP merged commit 2904b9f into corazawaf:main Jan 7, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants