-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #1266 @restpath failing on query string or extra path info #1267
Conversation
I wonder why no pipelines have run here 🤔 |
It's because I'm a first time contributor to this project- the pipelines require approval from a maintainer in order to run. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
+ Coverage 81.69% 81.76% +0.06%
==========================================
Files 169 169
Lines 9770 9770
==========================================
+ Hits 7982 7988 +6
+ Misses 1537 1533 -4
+ Partials 251 249 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There is an extra blank line that we can remove and I think we can merge. I'm trying to think more border cases, but at least there is additional coverage now.
Co-authored-by: Felipe Zipitría <[email protected]>
Removed additional blank line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me also!
This PR proposes a fix for #1266.
Make sure that you've checked the boxes below before you submit PR:
Thanks for your contribution ❤️