Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4 upgrade revised #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

4.4 upgrade revised #50

wants to merge 2 commits into from

Conversation

peterli-r3
Copy link
Contributor

No description provided.

This repository is divided into two parts: Java templates, and Kotlin templates. You may complete the training in whichever
language you prefer.
This repository is divided into two sections: Java templates, and Kotlin templates. You may complete the training in whichever language you prefer.
Open the corresponded folder `training-java` or `training-kotlin` in your choice of IDE and continue. (Don't start building the project in this parent folder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true? It looks like with this PR you would still open the parent folder no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to tell people don't open this project from the parent folder. And please open it from the corresponded folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't you open this project in IntelliJ from the root folder? The separation of java/kotlin is done through how the unit tests are run.

@amoothart
Copy link
Contributor

Some high level changes should be considered here:

  1. Do you really need to change the java/kotlin project structure at this point? This may need to be documented carefully and communicated to any instructors.
  2. The project is still using Corda 4.3
  3. The IntellIJ run configurations no longer work with the new folder structure.

@@ -1,150 +1,16 @@
![Corda](https://www.corda.net/wp-content/uploads/2016/11/fg005_corda_b.png)

# Corda Training Template
This repo contains material for the Corda two day training course. This course can be optionally prefaced by the content found in the hello-corda directory in the root of this repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you get rid of this? The statement is still true.

This repository is divided into two parts: Java templates, and Kotlin templates. You may complete the training in whichever
language you prefer.
This repository is divided into two sections: Java templates, and Kotlin templates. You may complete the training in whichever language you prefer.
Open the corresponded folder `training-java` or `training-kotlin` in your choice of IDE and continue. (Don't start building the project in this parent folder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't you open this project in IntelliJ from the root folder? The separation of java/kotlin is done through how the unit tests are run.

1. Corda version bump
2. Cordapp structural changes: separate flows and contracts/states
3. Spring server rewrite.

The upgraded code is done and you can see the preview at branch[ 4.4-update ](https://github.com/corda/corda-training-template/tree/4.4-update)
# Setup
Please re-structure your training accordingly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this statement mean? It would be helpful to give trainers direction on what you mean "accordingly".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants