-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.4 upgrade revised #50
base: master
Are you sure you want to change the base?
Conversation
This repository is divided into two parts: Java templates, and Kotlin templates. You may complete the training in whichever | ||
language you prefer. | ||
This repository is divided into two sections: Java templates, and Kotlin templates. You may complete the training in whichever language you prefer. | ||
Open the corresponded folder `training-java` or `training-kotlin` in your choice of IDE and continue. (Don't start building the project in this parent folder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true? It looks like with this PR you would still open the parent folder no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant to tell people don't open this project from the parent folder. And please open it from the corresponded folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wouldn't you open this project in IntelliJ from the root folder? The separation of java/kotlin is done through how the unit tests are run.
Some high level changes should be considered here:
|
@@ -1,150 +1,16 @@ | |||
![Corda](https://www.corda.net/wp-content/uploads/2016/11/fg005_corda_b.png) | |||
|
|||
# Corda Training Template | |||
This repo contains material for the Corda two day training course. This course can be optionally prefaced by the content found in the hello-corda directory in the root of this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you get rid of this? The statement is still true.
This repository is divided into two parts: Java templates, and Kotlin templates. You may complete the training in whichever | ||
language you prefer. | ||
This repository is divided into two sections: Java templates, and Kotlin templates. You may complete the training in whichever language you prefer. | ||
Open the corresponded folder `training-java` or `training-kotlin` in your choice of IDE and continue. (Don't start building the project in this parent folder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wouldn't you open this project in IntelliJ from the root folder? The separation of java/kotlin is done through how the unit tests are run.
1. Corda version bump | ||
2. Cordapp structural changes: separate flows and contracts/states | ||
3. Spring server rewrite. | ||
|
||
The upgraded code is done and you can see the preview at branch[ 4.4-update ](https://github.com/corda/corda-training-template/tree/4.4-update) | ||
# Setup | ||
Please re-structure your training accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this statement mean? It would be helpful to give trainers direction on what you mean "accordingly".
No description provided.