feat(minato): add primary type for auto generated primary key
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(mongo): `primary` work as ObjectId Signed-off-by: Hieuzest <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 98.04% 98.05%
=======================================
Files 23 23
Lines 4652 4670 +18
Branches 1142 1150 +8
=======================================
+ Hits 4561 4579 +18
Misses 91 91
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shigma
reviewed
Aug 21, 2023
packages/core/src/model.ts
Outdated
|
|
||
| export type Type<T = any> = | ||
| | T extends number ? 'integer' | 'unsigned' | 'float' | 'double' | 'decimal' | ||
| : T extends string ? 'char' | 'string' | 'text' | ||
| : T extends boolean ? 'boolean' | ||
| : T extends Date ? 'timestamp' | 'date' | 'time' | ||
| : T extends unknown[] ? 'list' | 'json' | ||
| : T extends Primary ? 'primary' | 'unsigned' |
There was a problem hiding this comment.
unsigned refer to the original autoInc. This allows mongo users to only change type Primary and still use old style autoInc as kind of compatibility. Also i don't have to edit definitions in tests lol.
shigma
approved these changes
Aug 25, 2023
shigma
changed the title
primary type for auto generated primary keyprimary type for auto generated primary key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #35