Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Provider Pin & MIG Updates #9

Merged
merged 1 commit into from
Sep 3, 2024
Merged

GCP Provider Pin & MIG Updates #9

merged 1 commit into from
Sep 3, 2024

Conversation

thathaneydude
Copy link
Collaborator

Description

Fixing two issues:

  1. Issue where upgrading the instance template was unsuccessful due to name collision. Now we set a prefix.
  2. Pinned the terraform module to v5 as v6 broke the MIG API contract

Type of change

Please delete options that are not relevant.

  • Bug Fix
  • New Feature
  • This change requires a documentation update

How Has This Been Tested?

Tested locally successfully

@thathaneydude
making the mig instance template a prefix rather than a set name to h…
58dc1e8 
…elp with upgrades. Also pinned GCP provider to major version 5
@thathaneydude thathaneydude requested a review from retr0h September 3, 2024 21:46
@thathaneydude thathaneydude self-assigned this Sep 3, 2024
@thathaneydude thathaneydude merged commit 8893830 into main Sep 3, 2024
1 check passed
@thathaneydude thathaneydude deleted the pin-provider-version-and-mig-updates branch September 3, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retr0h retr0h Awaiting requested review from retr0h

Assignees

@thathaneydude thathaneydude

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thathaneydude