Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rust version from 1.39.0 to 1.40.0 #398

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

sohankunkerkar
Copy link
Member

@sohankunkerkar sohankunkerkar commented Apr 21, 2020

Current CI is unable to handle #[cfg(doctest)] tag in the code and throwing the following error:

error[E0658]: `cfg(doctest)` is experimental and subject to change

For more information: (https://travis-ci.org/github/coreos/afterburn/jobs/677790013#L412)

This PR fixes the above issue which is present in the rust v1.40.0 release.

@cgwalters
Copy link
Member

Current CI is unable to handle #[cfg(doctest)] tag in the code and throwing the following error:

Just a clarification: I think this is actually only happening when we pull in a new libsystemd-rs and one of its dependencies transitively goes to xml-rs which recently did this: netvl/xml-rs#185

But anyways, LGTM!

@cgwalters cgwalters merged commit bdaf33d into coreos:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants