This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Use nil-able fields in sugar sections #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2018 10:56
etcd, flannel, and locksmith all should have nil-able types since their command line interfaces may assume a non-zero default value. If our types are non-nilable then setting a field that has a non-zero default value is impossible. Make everything nil-able so we don't need to trawl through multiple codebases to determine which fields should or should not be. This also protects against changes in those projects breaking us.
cgonyeo
approved these changes
May 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coreos/bugs#2431
After OOB discussion with @dgonyeo we decided that making everything nilable was both easier and less error prone than auditing every field. It also future proofs it.
Throw in a commit to use
gofmt -dinstead ofgofmtbecause I'm tired of running./testthengofmt -d <some file>