Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yet another pattern to IsNotExist #108

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add yet another pattern to IsNotExist #108

merged 1 commit into from
Oct 23, 2023

Conversation

danwinship
Copy link
Contributor

#107 handled iptables-legacy but not iptables-nft.

Seen in https://github.com/containernetworking/plugins/actions/runs/5715835655/job/15486163430?pr=935:

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0003bdb20>: 
      running [/usr/sbin/iptables -t nat -D POSTROUTING -s 10.1.2.2 -j CNI-43a5a67926c1a665ff4c21b7 -m comment --comment name: "testConfig" id: "dummy-0" --wait]: exit status 2: iptables v1.8.7 (nf_tables): Chain 'CNI-43a5a67926c1a665ff4c21b7' does not exist

@danwinship
Copy link
Contributor Author

@squeed

@danwinship
Further fixes to IsNotExist
df891bf 
The last fix handled iptables-legacy but not iptables-nft.

Also, apparently since this is a weird "can't happen" race condition,
iptables exits with status 2 rather than 1, so remove that check.
@squeed squeed merged commit ec4e892 into coreos:main Oct 23, 2023
5 checks passed
@danwinship danwinship deleted the IsNotExist2 branch October 23, 2023 14:14
@irbekrm irbekrm mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danwinship @squeed