sdjournal: adds an async follower method #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good if you want to stream values from journald to a logging solution such as loggly. |
| @@ -188,6 +188,29 @@ process: | |||
| return | |||
| } | |||
|
|
|||
| func (r *JournalReader) FollowAsync(until <-chan time.Time, recieve chan<- []byte) <-chan error { | |||
There was a problem hiding this comment.
few things:
- please add a docstring
s/recieve/receive- probably need to add a note that the
untilchannel MUST be closed or this will leak a goroutine
faiq
force-pushed
the
master
branch
5 times, most recently
from
a216554 to
a9129f5
Compare
|
@jonboulle thanks for getting back to me so fast! ended up implementing all of your suggestions and it looking pretty good to me. Let me know if there are other things you'd like me to change as well! |
this allows users to pull data from journal entries that aren't MESSAGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows consumers to asynchronously receive values from journald. It seems like we don't need the polling logic that the regular follow method had. Would love to hear thoughts and suggestions!