compose: Add a "warn and sleep" if --unified-core is not provided #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashcrow
approved these changes
May 18, 2020
| else | ||
| { | ||
| /* Secret environment variable for those desparate */ | ||
| if (!g_getenv ("RPM_OSTREE_I_KNOW_NON_UNIFIED_CORE_IS_DEPRECATED")) |
|
If not already done, it may be worth adding it to the docs as well. Specifically that the switch is required. In terms of functionality this looks good 😄. |
cgwalters
force-pushed
the
warn-deprecated-non-unified-core
branch
from
a4a8fa9 to
56f63af
Compare
|
/lgtm |
cgwalters
force-pushed
the
warn-deprecated-non-unified-core
branch
from
56f63af to
a6b43d1
Compare
jlebon
reviewed
May 19, 2020
Start adding some pain if `--unified-core` isn't provided to help flush out anyone relying on it. (And I think today pungi is not passing it, so e.g. Fedora IoT/Silverblue are impacted) Prep for merging coreos#1793 Co-authored-by: Jonathan Lebon <[email protected]>
cgwalters
force-pushed
the
warn-deprecated-non-unified-core
branch
from
5e324e5 to
e120ee7
Compare
ashcrow
approved these changes
May 20, 2020
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracker: #729
Start adding some pain if
--unified-coreisn't providedto help flush out anyone relying on it. (And I think today
pungi is not passing it, so e.g. Fedora IoT/Silverblue are impacted)
Prep for merging #1793