aws-cloudformation#241 Updated to include unsupported keys

corey-cole · May 1, 2022 · 675bb87 · 675bb87
1 parent ab42796
commit 675bb87
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/guard-examples/external-cfn-parameters/check-wellformed-parameters-tests.yaml b/guard-examples/external-cfn-parameters/check-wellformed-parameters-tests.yaml
@@ -4,6 +4,7 @@
   expectations:
     rules:
       has_correct_keys: SKIP
+      has_likely_valid_arn: SKIP
 - name: FindsRequiredKeys
   input: [
     {"ParameterKey": "pIgnore", "ParameterValue": "arn:aws:s3:::bucket_name/key_name"}
@@ -12,6 +13,14 @@
     rules:
       has_correct_keys: PASS
       has_likely_valid_arn: PASS
+- name: FindsUnsupportedKeys
+  input: [
+    {"ParameterKey": "pIgnore", "ParameterValue": "whatever", "UsePreviousValue": "true"}
+  ]
+  expectations:
+    rules:
+      has_correct_keys: FAIL
+      has_likely_valid_arn: SKIP
 - name: FindsMalformedArn
   input: [
     {"ParameterKey": "pIgnore", "ParameterValue": "arn:aws:foo:bar:baz"}

diff --git a/guard-examples/external-cfn-parameters/check-wellformed-parameters.guard b/guard-examples/external-cfn-parameters/check-wellformed-parameters.guard
@@ -6,6 +6,8 @@ rule has_correct_keys when %all_parameters !empty {
         ParameterKey exists
         ParameterValue exists
         << Required keys exist >>
+        UsePreviousValue not exists
+        ResolvedValue not exists
     }
 }