Skip to content
This repository has been archived by the owner on Mar 21, 2020. It is now read-only.

Commit

Permalink
feat: Add Bulma and add Navbar to Layout (#237)
Browse files Browse the repository at this point in the history
In the process I installed Webpacker and got a JS pipeline going. This is how Bulma is running now, side by side with the asset pipeline for now.

Also upgraded to Rails 5.2 and got some specs running. They are just the ones that come with Clearance but that's gotta count for something right?

* Add webpacker and do webpacker install

* Get bulma added to the HTML

* Add navbar, it looks pretty reasonable. Static homepage is empty now

* Set some colors

* Install clearance views

* Ship some clearence feature specs. They fail right now because I don't require a password right now

* Get all specs passing by making password only optional if you have an omniauth authentication

* autocorrect

* Autogem rubocop todo

* Update all gems

* Lets just go to rails 5.2
  • Loading branch information
coreyja authored Feb 7, 2019
1 parent 4f50573 commit 7fabd6f
Show file tree
Hide file tree
Showing 48 changed files with 7,920 additions and 122 deletions.
18 changes: 18 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"presets": [
["env", {
"modules": false,
"targets": {
"browsers": "> 1%",
"uglify": true
},
"useBuiltIns": true
}]
],

"plugins": [
"syntax-dynamic-import",
"transform-object-rest-spread",
["transform-class-properties", { "spec": true }]
]
}
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,8 @@ bower.json

# Ignore Byebug command history file.
.byebug_history
/public/packs
/public/packs-test
/node_modules
yarn-debug.log*
.yarn-integrity
3 changes: 3 additions & 0 deletions .postcssrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
plugins:
postcss-import: {}
postcss-cssnext: {}
24 changes: 22 additions & 2 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2018-09-09 17:55:03 -0400 using RuboCop version 0.58.2.
# on 2019-02-07 00:37:03 -0500 using RuboCop version 0.58.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 2
Capybara/CurrentPathExpectation:
Exclude:
- 'spec/features/clearance/visitor_resets_password_spec.rb'
- 'spec/features/clearance/visitor_signs_up_spec.rb'

# Offense count: 1
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Expand All @@ -16,11 +22,25 @@ Lint/AssignmentInCondition:
Metrics/AbcSize:
Max: 22

# Offense count: 1
# Offense count: 2
# Configuration parameters: CountComments.
Metrics/MethodLength:
Max: 34

# Offense count: 1
RSpec/Be:
Exclude:
- 'spec/features/clearance/visitor_resets_password_spec.rb'

# Offense count: 5
RSpec/DescribeClass:
Exclude:
- 'spec/features/clearance/user_signs_out_spec.rb'
- 'spec/features/clearance/visitor_resets_password_spec.rb'
- 'spec/features/clearance/visitor_signs_in_spec.rb'
- 'spec/features/clearance/visitor_signs_up_spec.rb'
- 'spec/features/clearance/visitor_updates_password_spec.rb'

# Offense count: 2
Style/MixinUsage:
Exclude:
Expand Down
10 changes: 9 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ git_source(:github) do |repo_name|
end

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '~> 5.1.6'
gem 'rails', '~> 5.2.0'
# Use postgresql as the database for Active Record
gem 'pg', '~> 1.1'
# Use Puma as the app server
Expand Down Expand Up @@ -37,6 +37,8 @@ gem 'jbuilder', '~> 2.8'
# Use Capistrano for deployment
# gem 'capistrano-rails', group: :development

gem 'webpacker', '~> 3.5'

gem 'clearance'
gem 'clockwork'
gem 'ddtrace'
Expand All @@ -58,6 +60,12 @@ group :development, :test do
gem 'pry-rails'
gem 'pry-remote'
gem 'rubocop-coreyja', '0.2.0'

gem 'capybara'
gem 'capybara-selenium'
gem 'factory_bot_rails'
gem 'rspec'
gem 'rspec-rails'
end

group :development do
Expand Down
Loading

0 comments on commit 7fabd6f

Please sign in to comment.