-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Rewrite of nn
to enable runtime layer sizes, proc macro declarations, and more
#854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 18, 2023
coreylowman
changed the title
[Breaking] [WIP] Rewrite of
[Breaking] Rewrite of Oct 25, 2023
nn
to enable runtime layer sizes, proc macro declarations, and morenn
to enable runtime layer sizes, proc macro declarations, and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a rewrite of the
nn
layer to make a few things possible:Here's an example of both of these in action:
Here we define the MLP to have the input and output sizes known at compile time, but the interior hidden dimension is known at runtime. Since the struct has
#[derive(Sequential)]
, the layers are executed in order of declaration.Also notice the
#[built(Mlp)]
which indicates the name of the new type that is defined alongside this struct (which contains the actual modules).As far as instantiating this object, it's also pretty straightforward:
Note that you actually have to instantiate the architecture now as an object, instead of it being at type. This is to support runtime values.
Breaking changes
dfdx
has been renamed todfdx-core
and doesn't include nn items.dfdx
now contains the new nn items, and re-exports everything fromdfdx-core.
dfdx::optim
has been moved underdfdx::nn::optim
builders
structs are now structs with "Config" postfixed (e.g.LinearConfig
instead ofbuilders::Linear
)to_device
functionality removedto_dtype
functionality removedUnbiasedLinear
renamed toMatMul
GeneralizedResidual
renamed toGeneralizedAdd