Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method Counter::total() #20

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Add method Counter::total() #20

merged 2 commits into from
Apr 30, 2022

Conversation

clint-white
Copy link
Contributor

This is based on the method of the same name from Python's
collections.Counter, new in Python 3.10.

@clint-white
Add method Counter::total()
b0e3c56 
This is based on the method of the same name from Python's
`collections.Counter`, new in Python 3.10.
coriolinus
coriolinus reviewed Apr 30, 2022
View reviewed changes
Copy link
Owner

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! I'd like to reduce the use surface, but the fundamental logic definitely seems mergeable.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
coriolinus
coriolinus approved these changes Apr 30, 2022
View reviewed changes
Copy link
Owner

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for contributing this!

@coriolinus coriolinus merged commit 02eff96 into coriolinus:master Apr 30, 2022
@clint-white clint-white deleted the method-total branch April 30, 2022 21:38
@clint-white
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coriolinus coriolinus coriolinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clint-white @coriolinus