Skip to content

Commit

Permalink
feat(contourSeg) polyline decimate :: code review
Browse files Browse the repository at this point in the history
  • Loading branch information
lscoder committed Feb 8, 2024
1 parent e00a59f commit aefdbb0
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/tools/src/tools/annotation/LivewireContourTool.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class LivewireContourTool extends ContourSegmentationBaseTool {
* for better performance and storage.
*/
decimate: {
enabled: true,
enabled: false,
/** A maximum given distance 'epsilon' to decide if a point should or
* shouldn't be added the resulting polyline which will have a lower
* number of points for higher `epsilon` values.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ class PlanarFreehandROITool extends ContourSegmentationBaseTool {
* for better performance and storage.
*/
decimate: {
enabled: true,
enabled: false,
/** A maximum given distance 'epsilon' to decide if a point should or
* shouldn't be added the resulting polyline which will have a lower
* number of points for higher `epsilon` values.
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/src/tools/annotation/SplineROITool.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class SplineROITool extends ContourSegmentationBaseTool {
* for better performance and storage.
*/
decimate: {
enabled: true,
enabled: false,
/** A maximum given distance 'epsilon' to decide if a point should or
* shouldn't be added the resulting polyline which will have a lower
* number of points for higher `epsilon` values.
Expand Down
4 changes: 0 additions & 4 deletions packages/tools/src/tools/base/ContourBaseTool.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,6 @@ abstract class ContourBaseTool extends AnnotationTool {
}
) {
const decimateConfig = this.configuration?.decimate || {};
console.log('>>>>> decimate', {
enabled: !!decimateConfig.enabled,
epsilon: decimateConfig.epsilon,
});

updateContourPolyline(annotation, polylineData, transforms, {
decimate: {
Expand Down

0 comments on commit aefdbb0

Please sign in to comment.