You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This requires users to register two tools: StackScrollTool for touchDrag and mouseDrag events StackScrollToolMouseWheelTool for mouseWheel events
Rather than having two separate tools, we can merge the functionality of the mouseWheel callback into the stackScrollTool and provide an API to configure these callbacks on/off without the need to register a separate tool such as the below.
…tions (#254)
* chore: use the jest testing framework
* chore: switch to github actions
The NPM_TOKEN secret should be set in an environment called "publish"
Current cornerstone tools follow the structure of callbacks which are associated with events. For example,
https://github.com/cornerstonejs/cornerstone3D-beta/blob/2a336d5bd6bb0af865d99ffd8af48ba1ce779f64/packages/tools/src/tools/StackScrollTool.ts#L15-L19
There are currently tool some duplicates for different input types (e.g.)
https://github.com/cornerstonejs/cornerstone3D-beta/blob/2a336d5bd6bb0af865d99ffd8af48ba1ce779f64/packages/tools/src/tools/StackScrollToolMouseWheelTool.ts#L14-L15
This requires users to register two tools:
StackScrollTool
for touchDrag and mouseDrag eventsStackScrollToolMouseWheelTool
for mouseWheel eventsRather than having two separate tools, we can merge the functionality of the mouseWheel callback into the stackScrollTool and provide an API to configure these callbacks on/off without the need to register a separate tool such as the below.
Same convention can be applied to v3 Pan / MultiTouchPan, StackScroll MultiTouch, Zoom / Zoom pinch / Zoom wheel.
The text was updated successfully, but these errors were encountered: