Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measurement textbox update event missing #274

Open
kevinshen1101 opened this issue Nov 1, 2022 · 4 comments · May be fixed by #296
Open

Measurement textbox update event missing #274

kevinshen1101 opened this issue Nov 1, 2022 · 4 comments · May be fixed by #296

Comments

@kevinshen1101
Copy link
Contributor

In the old cornerstoneTools, when a measurement textbox was moved, a MEASUREMENT_MODIFIED event would be emitted. However, it seems that the current logic fails to emit an ANNOTATION_MODIFIED event when a measurement textbox is updated
@sedghi
Copy link
Member

sedghi commented Nov 1, 2022

I haven't looked into the old code but I think it makes sense, moving the measurement textBox does not update/modify the actual measurement

@kevinshen1101
Copy link
Contributor Author

Is there a way we can incorporate that logic? Seems to be available in the old code

@sedghi
Copy link
Member

sedghi commented Nov 1, 2022

What is your use case?

@kevinshen1101
Copy link
Contributor Author

We want to save all measurement updates in our web app in a DB. Ideally, when the user moves the measurement textbox, an ANNOTATION_UPDATED event will trigger and we will save it so that when the page is reloaded, the textbox renders in the same updated position.

@m00n620 m00n620 linked a pull request Nov 14, 2022 that will close this issue
Open
wayfarer3130 added a commit that referenced this issue Jan 20, 2023
@wayfarer3130
fix(proxy):Make the conceptCodeSequence generateReport a proxy (#274)
b5a8a99 
* fix(dcmjs):Make the conceptCodeSequence generateReport a proxy

The conceptCodeSequence generated by the generateReport is supposed
to be consistent with that generated by parsing, but because of the
proxy it wasn't consistent, so this change makes it consistent

* fix(dcmjs):Made a few more objects into proxies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: trigger annotation modified event on textbox moving m00n620/cornerstone3D
2 participants
@sedghi @kevinshen1101