You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit cd5efa0 introduced breaking changes. After an update of cornerstonetools from 1.14.3 to 1.14.4 position synchronization between StackViewports in our app silently stopped working. It happened because of this line in stackIageSyncCallback
If options are undefined as is in our case the app fails.
And what is even worse it is called from Synchronizer in such way that prevents errors or warnings to appear. The error happens inside a promise and there is absolutely no feedback to user. It just looks that synchronization doesn't work.
I'd like also to call attention to a fact that this happened in a supposedly trivial update from 1.14.3 to 1.14.4. I don't know, guys, maybe these options should always exist. But I can't find anything in docs about them for createStackImageSynchronizer and our app worked fine previously without them. And a patch update that changes the last number in a version is not supposed to have breaking changes. Especially when they break things silently.
For now I rollbacked. I hope you fix this error or at least provide me some information how to configure these options for a Synchronizer.
Thank you
Steps to Reproduce
I can't provide the whole setup of our app and I am too lazy to create a fresh app to reproduce it there. I believe I provided enough information in a previous section
The current behavior
Position synchronization between StackViewports doesn't work and shows no errors
The expected behavior
Position synchronization between StackViewports should work or at least inform a user that something went wrong
OS
macOS 13.4
Node version
16.15.1
Browser
Chrome 116.0.5845.187
The text was updated successfully, but these errors were encountered:
I was also facing same issue after update of cornerstonetools from 1.14.3 to 1.14.4.
I have resolved this with synchronizer.setOption() method while adding Viewport to Synchronizer.
Describe the Bug
This commit cd5efa0 introduced breaking changes. After an update of cornerstonetools from 1.14.3 to 1.14.4 position synchronization between StackViewports in our app silently stopped working. It happened because of this line in stackIageSyncCallback
const options = synchronizerInstance.getOptions(targetViewport.viewportId);
[...]
options.useInitialPosition !== false
If options are undefined as is in our case the app fails.
And what is even worse it is called from Synchronizer in such way that prevents errors or warnings to appear. The error happens inside a promise and there is absolutely no feedback to user. It just looks that synchronization doesn't work.
I'd like also to call attention to a fact that this happened in a supposedly trivial update from 1.14.3 to 1.14.4. I don't know, guys, maybe these
options
should always exist. But I can't find anything in docs about them for createStackImageSynchronizer and our app worked fine previously without them. And a patch update that changes the last number in a version is not supposed to have breaking changes. Especially when they break things silently.For now I rollbacked. I hope you fix this error or at least provide me some information how to configure these options for a Synchronizer.
Thank you
Steps to Reproduce
I can't provide the whole setup of our app and I am too lazy to create a fresh app to reproduce it there. I believe I provided enough information in a previous section
The current behavior
Position synchronization between StackViewports doesn't work and shows no errors
The expected behavior
Position synchronization between StackViewports should work or at least inform a user that something went wrong
OS
macOS 13.4
Node version
16.15.1
Browser
Chrome 116.0.5845.187
The text was updated successfully, but these errors were encountered: