[Bug] dicom-image-loader: createImage uses now undefined options.decodeConfig

[abustany]

Describe the Bug

Commit 85fd193 removed the decodeConfig member from option.ts (see the diff ), however that code is still used in createImage.ts, at least in version 1.34.0.

Steps to Reproduce

1. Upgrade to Cornerstone 1.34
2. Load a DICOM image (in my case through a stack viewport)

The current behavior

Error: createImage.ts:155 Uncaught (in promise) TypeError: Cannot destructure property 'use16BitDataType' of 'l2' as it is undefined.

The expected behavior

The image should load

OS

Linux

Node version

18.16.1

Browser

Chromium 119.0.6045.159, Firefox 120.0b9

[abustany]

For now I can workaround this bug doing the following in my Cornerstone init routine - not sure how safe that is:

  cornerstoneDICOMImageLoader.internal.setOptions({
    strict: false,
    decodeConfig: {
      convertFloatPixelDataToInt: true,
      use16BitDataType: false,
    },
  });

[sedghi]

Thanks for the report. @wayfarer3130 I don't think we should have touched this right?

[wayfarer3130]

@sedghi - yes, that was touched by Chris I think. There was an issue with having it in the decoder rather than in the params on the individual decode that was causing problems.

[sedghi]

@abustany Can you create a PR for this and revert the changes?

[abustany]

sure, will do

[abustany]

ah I missed that #926 also reverts the changes 🙈 oh well, feel free to close #929 then, if #926 gets merged first.