Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use callbacks to set headers for base loader #926

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

wayfarer3130
Copy link
Collaborator

Context

The new progressive retrieve doesn't go through the XMLHttpRequest framework, so is missing authentication headers.
This change only updates the default request to go through the old framework unless specifically configured otherwise.

Changes & Results

Testing

Run OHIF linked to this build against an OIDC provider, OR put a breakpoint in a provided beforeSend method to update the header values.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 23993ce
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/656f7f6c509d9b00087fb0da
😎 Deploy Preview https://deploy-preview-926--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Dec 4, 2023

@wayfarer3130 can you please revert this as well? #916

Copy link
Contributor

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sedghi sedghi merged commit 6df0c66 into main Dec 6, 2023
@wayfarer3130 wayfarer3130 deleted the fix/headers-with-large-images branch January 22, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants