Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interpolation): Contour segmentation interpolation for freehand and SplineROI #1003

Merged

Conversation

wayfarer3130
Copy link
Collaborator

@wayfarer3130 wayfarer3130 commented Jan 16, 2024

This PR is heavily based on the contour interpolation changes https://github.com/cornerstonejs/cornerstone3D/pull/966/files#diff-b23b56a65802245bafe668e7a0df8d734795f6af2c4326782464014f00c2d4c5
The original PR was for FlyWheel.io by @Belbin-GK

Context

  • Creates a contour tool that allows to create interpolated contour ROIs between contour drawn slices by FlyWheel.io
  • This allows to quickly create annotation in multiple slices for a tissue. Upcoming sculpt tool along with this feature will make editing the interpolated shapes easier.

Changes & Results

  • Add new interpolation for segmentation contours using polyline
  • Introduced 'autoGenerated' property in an annotation to indicate whether the annotation was manually created or automatically generated.
  • Added events for contour interpolation completion.
  • Allows separate styling for autoGenerated results

Testing

  • yarn example interpolationContourSegmentation.
  • Follow the instructions given in example file to generate interpolated contour ROI.
  • There is a Interpolation test file to run tests on the tool.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit de36dab
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65b020f8ea80d000082bca1c
😎 Deploy Preview https://deploy-preview-1003--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wayfarer3130 wayfarer3130 force-pushed the feat/contour-segmentation-interpolation branch from 5daa404 to 7285fd6 Compare January 17, 2024 21:52
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments. We're almost there, and I believe there are many areas where we can improve performance.

@sedghi sedghi changed the title feat: Contour segmentation interpolation feat(interpolation): Contour segmentation interpolation for freehand and SplineROI Jan 23, 2024
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Flywheel team for the initial work and your alley-oop and great work @wayfarer3130 to slam dunk it into our repo

@sedghi sedghi merged commit 8434c8e into cornerstonejs:main Jan 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants