-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interpolation): Contour segmentation interpolation for freehand and SplineROI #1003
feat(interpolation): Contour segmentation interpolation for freehand and SplineROI #1003
Conversation
…tion-interpolation
…tion-interpolation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5daa404
to
7285fd6
Compare
packages/tools/src/utilities/segmentation/InterpolationManager/updateRelatedAnnotations.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/segmentation/InterpolationManager/updateRelatedAnnotations.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/segmentation/InterpolationManager/updateRelatedAnnotations.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/contours/interpolation/getInterpolationDataCollection.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/contours/interpolation/getInterpolationDataCollection.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/contours/interpolation/getInterpolationData.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/contours/interpolation/getInterpolationData.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/contours/interpolation/findInterpolationList.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/contours/interpolation/findInterpolationList.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/contours/interpolation/findInterpolationList.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/contours/interpolation/findInterpolationList.ts
Outdated
Show resolved
Hide resolved
…tion-interpolation
packages/tools/src/utilities/contours/interpolation/interpolate.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/segmentation/InterpolationManager/deleteRelatedAnnotations.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/segmentation/InterpolationManager/deleteRelatedAnnotations.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/segmentation/InterpolationManager/deleteRelatedAnnotations.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/segmentation/InterpolationManager/InterpolationManager.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/segmentation/InterpolationManager/InterpolationManager.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/utilities/segmentation/InterpolationManager/InterpolationManager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comments. We're almost there, and I believe there are many areas where we can improve performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Flywheel team for the initial work and your alley-oop and great work @wayfarer3130 to slam dunk it into our repo
This PR is heavily based on the contour interpolation changes https://github.com/cornerstonejs/cornerstone3D/pull/966/files#diff-b23b56a65802245bafe668e7a0df8d734795f6af2c4326782464014f00c2d4c5
The original PR was for FlyWheel.io by @Belbin-GK
Context
Changes & Results
Testing
yarn example interpolationContourSegmentation
.Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment