-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Capture error messages thrown by vtk #1038
Conversation
fix: Calibrate RGB pixelData and be fault tolerant
After dragging the ellipse out of the boundary,a new elliptical ROI cannot be drawn in the viewport
Rollback code
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think this is related PR #1043 |
yes. dicom tag(00280004) is RGB. |
This is exactly what we're facing too. |
If someone can provide test data, I would be happy to test and merge this. Unfortunately, I cannot blindly approve it without the necessary information. |
The current This PR add the error handle part which can handle any error happened during |
Firstly,based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense thanks
Context
Due to vtk.js version update.
DataArray.js add conditional judgment
i think that we should add condition to capture error message in Vtk.
Changes & Results
Capture error information by dispatch
Events.IMAGE_LOAD_ERROR
Testing
after:

Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment