Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cache): Missing cached image to events details (removeImageLoadObject) #1040

Merged

Conversation

jlopes90
Copy link
Contributor

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 69e008f
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65b27885c15b2c0007537546
😎 Deploy Preview https://deploy-preview-1040--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Jan 26, 2024

Hmmm, actually seems like our event is not correct, it should be IMAGE_ABOUT_TO_BE_REMOVED (with your image if you like, not sure why you need this honestly) and the current one that says REMOVED with just imageId

@jlopes90
Copy link
Contributor Author

removeVolumeLoadObject has two volume and volumeId, I thought about doing the same as I did.

const eventDetails = {
volume: cachedVolume,
volumeId,
};

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fair enough

@sedghi sedghi merged commit 229f503 into cornerstonejs:main Jan 26, 2024
9 checks passed
@jlopes90 jlopes90 deleted the fix/missing-cached-image-to-event-details branch January 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants