fix: segmentSelect issue + segmentation modified event #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lscoder
force-pushed
the
fix/segmentSelect
branch
from
224b3a3 to
90a5925
Compare
sedghi
reviewed
Feb 8, 2024
| * @param annotation - Annotation to find the viewports that it could display in | ||
| * @returns All viewports to display in | ||
| */ | ||
| export default function getViewportsForAnnotation(annotation: Annotation) { |
There was a problem hiding this comment.
we have this already
packages/tools/src/utilities/getViewportForAnnotation.ts
There was a problem hiding this comment.
ViewportS (plural)
Later it looks for the viewport that is in a toolGroup with freehand tool
There was a problem hiding this comment.
Pushed a change to make getViewportForAnnotation call getViewportsForAnnotation removing duplicated code
sedghi
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
segmentSelectexample was not working as intendedSEGMENTATION_DATA_MODIFIEDwas not being triggered forPlanarFreehandContourSegmentationToolChanges & Results
contourSegmentationCompletedListenerfinds a viewport with PlanarFreehandContourSegmentationTool tool enabled