fix(polySeg): able to handle holes inside contour segmentation #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix/multiple-contour-interpolation
…ix/multiple-contour-interpolation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…at/labelmap-from-contour-with-holes
sedghi
commented
Feb 13, 2024
lscoder
reviewed
Feb 13, 2024
packages/tools/src/stateManagement/segmentation/polySeg/Labelmap/convertContourToLabelmap.ts
Show resolved
Hide resolved
packages/tools/src/stateManagement/segmentation/polySeg/Labelmap/convertContourToLabelmap.ts
Outdated
Show resolved
Hide resolved
lscoder
reviewed
Feb 13, 2024
lscoder
reviewed
Feb 13, 2024
lscoder
reviewed
Feb 13, 2024
lscoder
reviewed
Feb 13, 2024
lscoder
reviewed
Feb 13, 2024
lscoder
reviewed
Feb 15, 2024
Comment on lines
+25
to
+30
| function shuffleArray<T>(array: T[]): void { | ||
| for (let i = array.length - 1; i > 0; i--) { | ||
| const j = Math.floor(Math.random() * (i + 1)); | ||
| [array[i], array[j]] = [array[j], array[i]]; // Swap elements | ||
| } | ||
| } |
There was a problem hiding this comment.
👍
This way it runs in O(n) (faster) while the other option (sort + random) would run in O(n log(n)) (slower)
lscoder
approved these changes
Feb 15, 2024
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment