Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reset to center option for reset camera #269

Merged
merged 7 commits into from
Oct 31, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Oct 28, 2022

  • Refactored reset camera to use the setCamera (previous bug where resetting volumes where not updating camera because of clipping planes)
  • Added resetToCenter parameter to enable optional keeping the slice and just reseting the slice for volumes in any planes

Try example: https://deploy-preview-269--cornerstone-3d-docs.netlify.app/live-examples/resetcamera

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 7ffe4a8
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/63604684cdba56000c7ab75d
😎 Deploy Preview https://deploy-preview-269--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

physicalScale: radius,
physicalTranslation: focalPointToSet.map((v) => -v) as Point3,
clippingRange: clippingRangeToUse,
flipHorizontal: this.flipHorizontal ? false : undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused why this is here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will address it in the other pr

@sedghi sedghi merged commit 9539f6c into main Oct 31, 2022
wayfarer3130 pushed a commit that referenced this pull request Jan 20, 2023
@sedghi sedghi deleted the feat/reset-camera-resetToCenter branch January 22, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants