-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust canvas, not only off screen renderer on resize #279
fix: adjust canvas, not only off screen renderer on resize #279
Conversation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Interesting,
So I'm pretty sure in OHIF or consuming apps, collapsing the side panel would show a huge ugly white canvas for each viewport. Have you tried it in OHIF while collapsing sidebars and see what happens? |
Hmmmm, this wasn't the behavior I saw when resizing window. But I can try a side panel resize to see what happens. (chrome desktop) |
Here is with and without resize videos: OHIF Viewer without resize.webm |
327ef64
to
a22e2a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and It works great. Thanks
* Experiment Zero Copy Arrays * Update ValueRepresentation.js * Removed View
Fix for #2947