fix: ZoomTool fix for imageData spacing for PolyData files #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
reviewed
Nov 9, 2022
packages/tools/src/tools/ZoomTool.ts
Outdated
| const imageData = viewport.getImageData(); | ||
| // Added spacing preset in case there is no imageData on viewport | ||
| let spacing = [0.5, 0.5, 0.5]; | ||
| if (viewport.getImageData()) { |
There was a problem hiding this comment.
You can say const imageData = viewport.getImageData() and check on imageData instead of twice calling the viewport.geteImageData()
sedghi
reviewed
Nov 9, 2022
NeilMacPhee
force-pushed
the
ZoomToolFix
branch
from
e24d5b8 to
64e4ab3
Compare
wayfarer3130
pushed a commit
that referenced
this pull request
Jan 20, 2023
* moved "eslint-config-prettier" * update lock file Co-authored-by: flink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix