-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reference lines tool #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
force-pushed
the
feat/referenceLines
branch
from
November 11, 2022 03:00
19d4a28
to
5f8a416
Compare
swederik
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
swederik
reviewed
Nov 11, 2022
sedghi
force-pushed
the
feat/referenceLines
branch
from
November 11, 2022 13:13
262eb8e
to
3c5226e
Compare
NeilMacPhee
pushed a commit
to NeilMacPhee/cornerstone3D-beta
that referenced
this pull request
Nov 16, 2022
* initial commit for setting up * feat: add annotation display Tool * fix: reference lines render for parallel viewports * remove window assignment * apply review * remove stream for lerna * fix: reference lines for edge cases * fix types * fix naming * try to fix the api extractor
NeilMacPhee
pushed a commit
to NeilMacPhee/cornerstone3D-beta
that referenced
this pull request
Nov 22, 2022
* initial commit for setting up * feat: add annotation display Tool * fix: reference lines render for parallel viewports * remove window assignment * apply review * remove stream for lerna * fix: reference lines for edge cases * fix types * fix naming * try to fix the api extractor
NeilMacPhee
pushed a commit
to NeilMacPhee/cornerstone3D-beta
that referenced
this pull request
Nov 22, 2022
* initial commit for setting up * feat: add annotation display Tool * fix: reference lines render for parallel viewports * remove window assignment * apply review * remove stream for lerna * fix: reference lines for edge cases * fix types * fix naming * try to fix the api extractor
wayfarer3130
pushed a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-292--cornerstone-3d-docs.netlify.app/live-examples/referencelines